Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metric-based drills in dashboards #42727

Merged
merged 1 commit into from
May 16, 2024

Conversation

ranquild
Copy link
Contributor

Fixes #42656

QB has logic to turn models & metrics to ad-hoc question after change

newQuestion = newQuestion.setType("question");
. We need to a similar thing in dashboards. Each time when we navigate to a card and it became dirty, we need to convert this card to a an-doc question.

How to verify:

  • CI is green

@ranquild ranquild self-assigned this May 15, 2024
@ranquild ranquild requested a review from a team May 15, 2024 20:54
@ranquild ranquild added the no-backport Do not backport this PR to any branch label May 15, 2024
@metabase-bot metabase-bot bot added .Team/QueryingComponents visual Run Percy visual testing labels May 15, 2024
Copy link

Codenotify: Notifying subscribers in CODENOTIFY files for diff f7aef16...b07df19.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/lib/utils.js

Copy link

replay-io bot commented May 15, 2024

Status Complete ↗︎
Commit b07df19
Results
⚠️ 9 Flaky
2507 Passed

@ranquild ranquild merged commit 989e38d into metrics-v2 May 16, 2024
122 of 155 checks passed
@ranquild ranquild deleted the 42656-fix-underlying-records-metric branch May 16, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/QueryingComponents visual Run Percy visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants