Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

42701 search type ahead cp #42716

Merged
merged 3 commits into from
May 15, 2024
Merged

42701 search type ahead cp #42716

merged 3 commits into from
May 15, 2024

Conversation

npfitz
Copy link
Contributor

@npfitz npfitz commented May 15, 2024

Closes #42701

Description

Updating the command palette to respect the search-typeahead-enabled setting. If set to true, we should not perform searches

How to verify

  1. Start metabase with MB_SEARCH_TYPEAHEAD_ENABLED=false
  2. Open the command palette and enter a search query
  3. You should see the command palette show you a link to the search page, instead of showing you any search results

Demo

image

Checklist

  • Tests have been added/updated to cover changes in this PR

@npfitz npfitz added the no-backport Do not backport this PR to any branch label May 15, 2024
@npfitz npfitz requested a review from a team May 15, 2024 18:10
@npfitz npfitz self-assigned this May 15, 2024
@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 15, 2024
Copy link

replay-io bot commented May 15, 2024

Status Complete ↗︎
Commit ed85911
Results
⚠️ 3 Flaky
2506 Passed

@npfitz npfitz force-pushed the 42701-search-type-ahead-cp branch from 4728e1e to ed85911 Compare May 15, 2024 20:56
@npfitz npfitz merged commit 62754d5 into master May 15, 2024
112 checks passed
@npfitz npfitz deleted the 42701-search-type-ahead-cp branch May 15, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect search-type-ahead setting in command palette
2 participants