Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken pivot table questions that had out of date viz settings #42698

Merged
merged 3 commits into from
May 16, 2024

Conversation

ranquild
Copy link
Contributor

@ranquild ranquild commented May 15, 2024

Fixes #42697
Started from https://metaboat.slack.com/archives/C05MPF0TM3L/p1715724408732989

If leftHeaderWidths viz setting goes out of sync with the query, reset the setting to the default value and do not break the chart.

Before
Screenshot 2024-05-15 at 14 34 49

After
Screenshot 2024-05-15 at 14 34 18

@ranquild ranquild self-assigned this May 15, 2024
@ranquild ranquild added the backport Automatically create PR on current release branch on merge label May 15, 2024
@ranquild ranquild changed the title Recalculate leftHeaderWidths if it goes out of sync with data Fix broken pivot table questions that had out of date viz settings May 15, 2024
@ranquild ranquild requested review from alxnddr and a team May 15, 2024 18:36
@ranquild ranquild marked this pull request as ready for review May 15, 2024 18:36
@metabase-bot metabase-bot bot added the visual Run Percy visual testing label May 15, 2024
Copy link

github-actions bot commented May 15, 2024

Codenotify: Notifying subscribers in CODENOTIFY files for diff e23e654...18163e9.

Notify File(s)
@alxnddr frontend/src/metabase/visualizations/visualizations/PivotTable/PivotTable.tsx

Copy link

replay-io bot commented May 15, 2024

Status Complete ↗︎
Commit 18163e9
Results
⚠️ 5 Flaky
2504 Passed

@ranquild ranquild requested a review from a team May 16, 2024 12:12
Copy link
Contributor

@uladzimirdev uladzimirdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ranquild ranquild merged commit 0147c69 into master May 16, 2024
115 checks passed
@ranquild ranquild deleted the 42697-pivot-left-header-widths branch May 16, 2024 13:53
Copy link

@ranquild Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Automatically create PR on current release branch on merge support/Repro .Team/QueryingComponents visual Run Percy visual testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pivot table becomes broken if a breakout clause is added without visualizing the question
2 participants