Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move createMockModelResult to browse folder #42690

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

rafpaf
Copy link
Contributor

@rafpaf rafpaf commented May 15, 2024

Small refactor: move a test helper function, createMockModelResult, to the browse folder since it's specific to that part of the app.

Copy link
Contributor Author

rafpaf commented May 15, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rafpaf and the rest of your teammates on Graphite Graphite

@metabase-bot metabase-bot bot added the .Team/AdminWebapp Admin and Webapp team label May 15, 2024
@rafpaf rafpaf marked this pull request as ready for review May 15, 2024 13:13
@graphite-app graphite-app bot added the no-backport Do not backport this PR to any branch label May 15, 2024
@graphite-app graphite-app bot requested a review from a team May 15, 2024 13:13
Copy link

graphite-app bot commented May 15, 2024

Graphite Automations

"Notify author when CI fails" took an action on this PR • (05/15/24)

1 teammate was notified to this PR based on Raphael Krut-Landau's automation.

"Don't backport" took an action on this PR • (05/15/24)

1 label was added and 1 reviewer was added to this PR based on Raphael Krut-Landau's automation.

Copy link

replay-io bot commented May 15, 2024

Status Complete ↗︎
Commit 22a132d
Results
⚠️ 2 Flaky
2506 Passed

@rafpaf rafpaf force-pushed the move-createMockSearchResult branch from 8eb4a37 to 5b4fa2a Compare May 15, 2024 20:38
@rafpaf rafpaf merged commit 95d5a82 into master May 15, 2024
111 checks passed
@rafpaf rafpaf deleted the move-createMockSearchResult branch May 15, 2024 21:23
Copy link
Contributor Author

rafpaf commented May 15, 2024

Merge activity

Copy link

@rafpaf Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?

@rafpaf rafpaf added this to the 0.50 milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/AdminWebapp Admin and Webapp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants