-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs - update appearance settings #42388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested some changes but won't block on it.
|
||
## Conceal Metabase | ||
|
||
In the Conceal Metabase tab, you can show or hide Metabase-branded UI elements and links (like in-app links to Metabase's documentation). If you're embedding Metabase in your app, here are some settings you might want to change: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're embedding Metabase in your app, here are some settings you might want to change:
Comment
This reads like a general suggestion for everyone using embedding. I think there's some subtlety to it.
- app name, docs and references, hiding help link and MB illustrations are not relevant to static embedding, only interactive.
- for interactive embedding, docs and references is indeed relevant but since there is a trade-off (product becomes harder to use) not everyone might want to turn these off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TL;DR
If you are embedding Metabase in your app -> "If you are using interactive embedding" or similar....
Then perhaps add a sentence around the trade-off when hiding links and references?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to defer to the in-product text here:
Hide or customize pieces of the Metabase product to tailor the experience to your brand and needs
@jeff-bruemmer Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone? |
Updates docs on appearance settings for Metabase 50.