[QP, lib] Allow multiple arguments to :contains, :starts-with, etc.

[bshepherdson]

These string matching clauses only allowed two arguments previously.
Typically [:contains field x] to match a field against a literal.

This adds similar desugaring for :contains, :does-not-contain,
:starts-with and :ends-with that is currently done for
multi-argument := and :!=:

[:contains field x y z] ;; ->
[:or [:contains field x] [:contains field y] [:contains field z]]

[:does-not-contain field x y z] ;; ->
[:and [:does-not-contain field x]
      [:does-not-contain field y]
      [:does-not-contain field z]]

Part of epic #41956.

[bshepherdson]

• [QP, lib] Allow multiple arguments to :contains, :starts-with, etc. #41958 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bshepherdson and the rest of your teammates on Graphite

[replay-io]

Status	Complete ↗︎
Commit	fba27e4
Results	⚠️ 6 Flaky ✅ 2443 Passed

[metamben]

LGTM, but I expected new test cases for the now-muilt-arg functions other than :does-not-contain too.

[ranquild]

@bshepherdson when we attempt to create a contains filter with 2 values it fails

#error {:message "Error calculating display info for contains: Error calculating metadata for :contains: Error calculating column name for [:contains {:case-sensitive false, :lib/uuid \"c51e0fc5-7ef8-4ec1-847b-219940206a15\"} [:field {:base-type :type/Text, :lib/uuid \"303f37e1-187d-4b90-91cf-d215b750e948\"} 70] \"a\" \"b\"]: Cannot read properties of null (reading 'replace')", :data {:query {:lib/type :mbql/query, :stages [{:lib/type :mbql.stage/mbql, :source-table 8, :filters [[:contains {:case-sensitive false, :lib/uuid "c51e0fc5-7ef8-4ec1-847b-219940206a15"} [:field {:base-type :type/Text, :lib/uuid "303f37e1-187d-4b90-91cf-d215b750e948"} 70] "a" "b"]]}], :database 1, :lib/metadata #object[metabase.lib.js.metadata.t_metabase$lib$js$metadata70135]}, :stage-number -1, :x [:contains {:case-sensitive false, :lib/uuid "c51e0fc5-7ef8-4ec1-847b-219940206a15"} [:field {:base-type :type/Text, :lib/uuid "303f37e1-187d-4b90-91cf-d215b750e948"} 70] "a" "b"]}, :cause #error {:message "Error calculating metadata for :contains: Error calculating column name for [:contains {:case-sensitive false, :lib/uuid \"c51e0fc5-7ef8-4ec1-847b-219940206a15\"} [:field {:base-type :type/Text, :lib/uuid \"303f37e1-187d-4b90-91cf-d215b750e948\"} 70] \"a\" \"b\"]: Cannot read properties of null (reading 'replace')", :data {:query {:lib/type :mbql/query, :stages [{:lib/type :mbql.stage/mbql, :source-table 8, :filters [[:contains {:case-sensitive false, :lib/uuid "c51e0fc5-7ef8-4ec1-847b-219940206a15"} [:field {:base-type :type/Text, :lib/uuid "303f37e1-187d-4b90-91cf-d215b750e948"} 70] "a" "b"]]}], :database 1, :lib/metadata #object[metabase.lib.js.metadata.t_metabase$lib$js$metadata70135]}, :stage-number -1, :x [:contains {:case-sensitive false, :lib/uuid "c51e0fc5-7ef8-4ec1-847b-219940206a15"} [:field {:base-type :type/Text, :lib/uuid "303f37e1-187d-4b90-91cf-d215b750e948"} 70] "a" "b"]}, :cause #error {:message "Error calculating column name for [:contains {:case-sensitive false, :lib/uuid \"c51e0fc5-7ef8-4ec1-847b-219940206a15\"} [:field {:base-type :type/Text, :lib/uuid \"303f37e1-187d-4b90-91cf-d215b750e948\"} 70] \"a\" \"b\"]: Cannot read properties of null (reading 'replace')", :data {:x [:contains {:case-sensitive false, :lib/uuid "c51e0fc5-7ef8-4ec1-847b-219940206a15"} [:field {:base-type :type/Text, :lib/uuid "303f37e1-187d-4b90-91cf-d215b750e948"} 70] "a" "b"], :query {:lib/type :mbql/query, :stages [{:lib/type :mbql.stage/mbql, :source-table 8, :filters [[:contains {:case-sensitive false, :lib/uuid "c51e0fc5-7ef8-4ec1-847b-219940206a15"} [:field {:base-type :type/Text, :lib/uuid "303f37e1-187d-4b90-91cf-d215b750e948"} 70] "a" "b"]]}], :database 1, :lib/metadata #object[metabase.lib.js.metadata.t_metabase$lib$js$metadata70135]}, :stage-number -1}, :cause #object[TypeError TypeError: Cannot read properties of null (reading 'replace')]}}}

[bshepherdson]

@ranquild I'm reworking this PR a bit internally based on an out-of-band review from Cam. I'll make sure it works at the lib level before submitting it.

[bshepherdson]

@ranquild @nemanjaglumac This should be working from the JS side now.

[github-actions]

@bshepherdson Did you forget to add a milestone to the issue for this PR? When and where should I add a milestone?