Make resolve-private-key include private-key-options in database details
#41941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decode the value by default to match behavior of `file-upload-props`.
lbrdnk
added
the
backport
|
This reverts commit 40c70a9.
lbrdnk
force-pushed
the
snowflake-rsa-41852
branch
from
40fa646
to
42852c8
Compare
lbrdnk
changed the title
file-upload-props in get-secrect-stringresolve-private-key include private-key-options set in database details
lbrdnk
changed the title
resolve-private-key include private-key-options set in database detailsresolve-private-key include private-key-options in database details
bshepherdson
approved these changes
Apr 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2024
…details (#41941) * Update resolve-private-key and add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41852
When
hostingfeature is enabled, database edit GUI does not sendprivate-key-optionsas part of request.secret/get-secrect-stringdepends on that value to determine if value should base64 decoded. This PR ensures the value of the key is set correctly inresolve-private-key.