Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background color settings for dashboard and visualization background in embedding SDK #42678

Open
1 task done
Tracked by #42694
heypoom opened this issue May 15, 2024 · 1 comment
Open
1 task done
Tracked by #42694
Assignees

Comments

@heypoom
Copy link
Contributor

heypoom commented May 15, 2024

Implement background color settings for the embedding SDK.

Blockers

Theme Options

  • ✅ Popover background settings
  • Visualization & dashcard background settings
    • Apply background color to dashcard container in embedded dashboards
    • Apply background color to question/visualization container in embedded questions
  • Dashboard background settings
    • Default to unset/transparent

Considerations

  • We can either use the theme.colors field (e.g. bg-visualization), or we can make this a theme option (e.g. theme.visualization.backgroundColor)
@heypoom heypoom self-assigned this May 20, 2024
@heypoom heypoom changed the title Background color settings for popovers and visualizations in embedding SDK Background color settings for visualizations and dashboard background in embedding SDK May 20, 2024
@heypoom heypoom removed their assignment May 20, 2024
@heypoom heypoom changed the title Background color settings for visualizations and dashboard background in embedding SDK Background color settings for dashboard and visualization background in embedding SDK May 20, 2024
@heypoom
Copy link
Contributor Author

heypoom commented May 20, 2024

@albertoperdomo @NevRA FYI, I moved this to Milestone 3 because of a hard dependency on Static Dashboard. Denis already implemented background for popovers in the drills PR, but the other 2 (dashcard background, embedded dashboard background) all requires Static Dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants