Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text colors should follow the background based on color contrast in embedding SDK #42686

Closed
Tracked by #42694
heypoom opened this issue May 15, 2024 · 1 comment
Closed
Tracked by #42694

Comments

@heypoom
Copy link
Contributor

heypoom commented May 15, 2024

We should provide support for both light-theme and dark-theme users of the sdk by providing automatic contrast detection. The idea is that foreground color should follow the background color defined in #42678 by detecting whether the background is dark or light mode.

@heypoom
Copy link
Contributor Author

heypoom commented May 27, 2024

Closing this issue as we already provide text-primary, text-secondary and text-tertiary settings that the user can control. Refer to the discussion here.

@heypoom heypoom closed this as completed May 27, 2024
@heypoom heypoom assigned heypoom and unassigned heypoom May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant