Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vsphere-iso support #533

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

fatz
Copy link
Contributor

@fatz fatz commented Oct 13, 2022

What problem does this PR solve?:
The current vsphere images need a base image which the user has to build before with their own packer install out of KIB. KIB should make it easy for users to build images without any other dependencies.

This PR adds support to build KIB images from ISOs initially supporting EL(RHEL and CentOS) as well as Ubuntu

bin/konvoy-image build vsphere-iso --help
build and provision vsphere images from ISO

Usage:
  konvoy-image build vsphere-iso <image.yaml> [flags]

Examples:
vsphere-iso --vsphere-datacenter=dc1 --vsphere-cluster=zone1 --vsphere-network=Public --vsphere-datastore=datastore1 images/vsphere-iso/ubuntu-2004.yaml

Flags:
      --containerd-version string      the version of containerd to install
      --dry-run                        do not create artifacts, or delete them after creating. Recommended for tests.
      --extra-vars strings             flag passed Ansible's extra-vars
  -h, --help                           help for vsphere-iso
      --iso-checksum string            replace the templates iso checksum
      --iso-url string                 replace the templates iso url
      --kubernetes-version string      The version of kubernetes to install. Example: 1.21.6
      --overrides strings              a comma separated list of override YAML files
      --packer-manifest string         provide the path to a custom packer manifest
      --packer-on-error string         [advanced] set error strategy for packer. strategies [cleanup, abort, run-cleanup-provisioner]
      --packer-path string             the location of the packer binary (default "packer")
      --ssh-username string            specify the initial user which gets SUDO permissions
      --vcenter-server string          vCenter server address (or environment variable VSPHERE_SERVER)
      --vsphere-cluster string         vSphere cluster name
      --vsphere-datacenter string      vSphere data center name
      --vsphere-datastore string       vSphere datastore to be used
      --vsphere-folder string          place VM in vSphere folder
      --vsphere-insecure-connection    ignore SSL certificate errors
      --vsphere-network string         specify vSphere resource pool for the build VM
      --vsphere-password string        vSphere password (or environment variable VSPHERE_PASSWORD)
      --vsphere-resource-pool string   specify vSphere resource pool for the build VM
      --vsphere-user string            vSphere user (or environment variable VSPHERE_USER)
      --work-dir string                path to custom work directory generated by the generate command

Global Flags:
      --color     enable color output (default true)
  -v, --v int     select verbosity level, should be between 0 and 6
      --verbose   enable debug level logging (same as --v 5)

This PR has packer HCL templates as a prerequisite thus its based on #507

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

- feat: vsphere-iso adds support using ISO images to build KIB images on vSphere

@fatz fatz changed the title WIP feat: add vsphere-iso support feat: add vsphere-iso support Oct 14, 2022
@fatz fatz requested review from faiq and supershal October 14, 2022 15:11
@github-actions github-actions bot added feature and removed feature labels Oct 14, 2022
@fatz fatz force-pushed the julferts/feat-hcl-vsphere-iso branch from c422cad to 04ceedb Compare October 15, 2022 11:02
@supershal supershal force-pushed the julferts/feat-hcl-vsphere-iso branch from 4518717 to 8c55b7c Compare January 30, 2023 19:17
@supershal
Copy link
Collaborator

supershal commented Mar 23, 2023

@fatz please confirm: we should not need this PR in favor of #716 and https://github.com/mesosphere/vsphere-base-template

@fatz
Copy link
Contributor Author

fatz commented Mar 24, 2023

I guess we should have a product decision about this.

So our current setup expects a specially prepared template which needs static ssh key access being baked into the template as long as #716 is not merged.

These are very strict conditions which are known to be problematic as response from the field was that customer images are typically not fulfill these expectations

This PR allows the customer to build a KIB image directly from an ISO source which should be way easier to use and lowers the amount of sources for failure drastically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants