-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add licensing tiers to Kommander Apps. #2227
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
services/kiali
services/fluent-bit
services/logging-operator
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
services/rook-ceph-cluster
services/rook-ceph
services/gatekeeper
services/istio
services/jaeger
services/external-dns
services/nvidia-gpu-operator
services/traefik
services/reloader
services/grafana-logging
services/cert-manager
services/kube-prometheus-stack
services/knative
services/kubecost
services/prometheus-adapter
services/traefik-forward-auth
services/velero
services/grafana-loki
services/project-grafana-loki
services/project-logging
services/project-grafana-logging
services/kubernetes-dashboard
services/kube-oidc-proxy
services/chartmuseum
labels
May 14, 2024
2 tasks
kaiwalyajoshi
removed
the
do-not-merge/testing
Do not merge because there is still on-going testing
label
May 15, 2024
github-actions
bot
added
the
do-not-merge/testing
Do not merge because there is still on-going testing
label
May 15, 2024
how about |
gracedo
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kommander-applications/services/kommander/0.12.0/defaults/cm.yaml
Lines 69 to 77 in 2ae3273
defaultEnterpriseApps: | |
- "centralized-kubecost" | |
- "kubecost" | |
- "kubecost-thanos-traefik" | |
- "centralized-grafana" | |
- "karma" | |
- "karma-traefik" | |
- "prometheus-thanos-traefik" | |
- "thanos" |
These "internal" apps are deployed by default on the mgmt cluster today when an enterprise license is applied -- do we need to do the same for an Ultimate license? I noticed that these apps also don't have the
licensing
key applied, is this because they are not exposed to the UI to begin with? Just wondering if it would make sense to add it just for "completeness" in case we end up wanting to expose them to the UI (for example, if we do not deploy them by default via controller, there is no other way for a user to enable them except manually using CLI)
github-actions
bot
added
services/gitea
services/kommander
services/kommander-flux
services/centralized-grafana
services/centralized-kubecost
services/dex-k8s-authenticator
services/dkp-insights-management
services/karma
services/karma-traefik
services/kubecost-thanos-traefik
services/prometheus-thanos-traefik
services/traefik-forward-auth-mgmt
services/kubefed
services/kubetunnel
services/thanos
services/kommander-appmanagement
services/dex
services/kommander-ui
services/git-operator
labels
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
do-not-merge/testing
Do not merge because there is still on-going testing
ok-to-test
Signals mergebot that CI checks are ready to be kicked off
open-kommander-pr
Automatically triggers the creation of a PR in Kommander repo
ready-for-review
services/ai-navigator-app
services/ai-navigator-cluster-info-agent
services/centralized-grafana
services/centralized-kubecost
services/cert-manager
services/chartmuseum
services/dex
services/dex-k8s-authenticator
services/dkp-insights
services/dkp-insights-management
services/external-dns
services/fluent-bit
services/gatekeeper
services/git-operator
services/gitea
services/grafana-logging
services/grafana-loki
services/istio
services/jaeger
services/karma
services/karma-traefik
services/kiali
services/knative
services/kommander
services/kommander-appmanagement
services/kommander-flux
services/kommander-ui
services/kube-oidc-proxy
services/kube-prometheus-stack
services/kubecost
services/kubecost-thanos-traefik
services/kubefed
services/kubernetes-dashboard
services/kubetunnel
services/logging-operator
services/nfs-server-provisioner
services/nvidia-gpu-operator
services/project-grafana-logging
services/project-grafana-loki
services/project-logging
services/prometheus-adapter
services/prometheus-thanos-traefik
services/reloader
services/rook-ceph
services/rook-ceph-cluster
services/thanos
services/traefik
services/traefik-forward-auth
services/traefik-forward-auth-mgmt
services/velero
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
update-licenses
signals mergebot to update licenses.d2iq.yaml
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Add Licensing Tier Annotations as per the Feature Matrix.
Which issue(s) does this PR fix?:
JIRA: https://jira.nutanix.com/browse/NCN-100668
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist