Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add licensing tiers to Kommander Apps. #2227

Merged
merged 6 commits into from
May 22, 2024

Conversation

kaiwalyajoshi
Copy link
Contributor

What problem does this PR solve?:

Add Licensing Tier Annotations as per the Feature Matrix.

Which issue(s) does this PR fix?:

JIRA: https://jira.nutanix.com/browse/NCN-100668

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@kaiwalyajoshi kaiwalyajoshi removed the do-not-merge/testing Do not merge because there is still on-going testing label May 15, 2024
@github-actions github-actions bot added the do-not-merge/testing Do not merge because there is still on-going testing label May 15, 2024
@cwyl02
Copy link
Contributor

cwyl02 commented May 16, 2024

how about centralized-grafana, centralized-kubecost and karma?

Copy link
Contributor

@gracedo gracedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defaultEnterpriseApps:
- "centralized-kubecost"
- "kubecost"
- "kubecost-thanos-traefik"
- "centralized-grafana"
- "karma"
- "karma-traefik"
- "prometheus-thanos-traefik"
- "thanos"

These "internal" apps are deployed by default on the mgmt cluster today when an enterprise license is applied -- do we need to do the same for an Ultimate license? I noticed that these apps also don't have the licensing key applied, is this because they are not exposed to the UI to begin with? Just wondering if it would make sense to add it just for "completeness" in case we end up wanting to expose them to the UI (for example, if we do not deploy them by default via controller, there is no other way for a user to enable them except manually using CLI)

@kaiwalyajoshi
Copy link
Contributor Author

@gracedo @cwyl02 added licensing tiers to all K-Apps now, including the internal ones.

@kaiwalyajoshi kaiwalyajoshi merged commit 3b1ca53 into main May 22, 2024
166 of 172 checks passed
@kaiwalyajoshi kaiwalyajoshi deleted the kjoshi/nkp-licensing-tier-annotations branch May 22, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo ready-for-review services/ai-navigator-app services/ai-navigator-cluster-info-agent services/centralized-grafana services/centralized-kubecost services/cert-manager services/chartmuseum services/dex services/dex-k8s-authenticator services/dkp-insights services/dkp-insights-management services/external-dns services/fluent-bit services/gatekeeper services/git-operator services/gitea services/grafana-logging services/grafana-loki services/istio services/jaeger services/karma services/karma-traefik services/kiali services/knative services/kommander services/kommander-appmanagement services/kommander-flux services/kommander-ui services/kube-oidc-proxy services/kube-prometheus-stack services/kubecost services/kubecost-thanos-traefik services/kubefed services/kubernetes-dashboard services/kubetunnel services/logging-operator services/nfs-server-provisioner services/nvidia-gpu-operator services/project-grafana-logging services/project-grafana-loki services/project-logging services/prometheus-adapter services/prometheus-thanos-traefik services/reloader services/rook-ceph services/rook-ceph-cluster services/thanos services/traefik services/traefik-forward-auth services/traefik-forward-auth-mgmt services/velero size/L Denotes a PR that changes 100-499 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
4 participants