Update PHPStan configuration and refactor Task service

The commit mainly updates the PHPStan configuration in the Makefile and phpstan.neon.dist, increasing memory limit and setting parallel processing parameters. It also refactors the Task service by expanding function parameter arrays into multiple lines for improved readability and maintainability. Signed-off-by: mesilov <mesilov.maxim@gmail.com>
mesilov · May 5, 2024 · 5e5a7c4 · 5e5a7c4
1 parent 6a37629
commit 5e5a7c4
Show file tree

Hide file tree

Showing 3 changed files with 53 additions and 5 deletions.
diff --git a/Makefile b/Makefile
@@ -3,7 +3,7 @@ default:
 	@egrep -e '^\S+' ./Makefile | grep -v default | sed -r 's/://' | sed -r 's/^/ - /'
 
 phpstan:
-	vendor/bin/phpstan analyse
+	vendor/bin/phpstan --memory-limit=1G analyse
 
 test-unit:
 	vendor/bin/phpunit --testsuite unit_tests
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -3,4 +3,10 @@ parameters:
   paths:
     - src/
   bootstrapFiles:
-    - tests/bootstrap.php
+    - tests/bootstrap.php
+  parallel:
+    jobSize: 20
+    maximumNumberOfProcesses: 8
+    minimumNumberOfJobsPerProcess: 2
+  editorUrlTitle: '%%relFile%%:%%line%%'
+  editorUrl: 'phpstorm://open?file=%%file%%&line=%%line%%'
diff --git a/src/Services/Workflows/Task/Service/Task.php b/src/Services/Workflows/Task/Service/Task.php
@@ -39,8 +39,50 @@ public function __construct(
      * To request personal tasks, non-administrator should not specify filter for USER_ID
      *
      * @param array $order
-     * @param array $filter
-     * @param array{'ID':int, 'WORKFLOW_ID'?:string, 'DOCUMENT_NAME'?:string, 'DESCRIPTION'?:string, 'NAME'?:string, 'MODIFIED'?: CarbonImmutable, 'WORKFLOW_STARTED'?: CarbonImmutable, 'WORKFLOW_STARTED_BY'?: int, 'OVERDUE_DATE'?: CarbonImmutable, 'WORKFLOW_TEMPLATE_ID'?:int, 'WORKFLOW_TEMPLATE_NAME'?:string, 'WORKFLOW_STATE'?: string, 'STATUS'?:WorkflowTaskStatusType, 'USER_ID'?:int, 'USER_STATUS'?:WorkflowTaskUserStatusType, 'MODULE_ID'?:string, 'ENTITY'?:DocumentType, 'DOCUMENT_ID'?:int, 'ACTIVITY': WorkflowTaskActivityType, 'PARAMETERS'?:array, 'DOCUMENT_URL'?:string} $select
+     * @param array|array{
+     *     ID?:int,
+     *     WORKFLOW_ID?:string,
+     *     DOCUMENT_NAME?:string,
+     *     DESCRIPTION?:string,
+     *     NAME?:string,
+     *     MODIFIED?: CarbonImmutable,
+     *     WORKFLOW_STARTED?: CarbonImmutable,
+     *     WORKFLOW_STARTED_BY?: int,
+     *     OVERDUE_DATE?: CarbonImmutable,
+     *     WORKFLOW_TEMPLATE_ID?:int,
+     *     WORKFLOW_TEMPLATE_NAME?:string,
+     *     WORKFLOW_STATE?: string,
+     *     STATUS?:WorkflowTaskStatusType,
+     *     USER_ID?:int,
+     *     USER_STATUS?:WorkflowTaskUserStatusType,
+     *     MODULE_ID?:string,
+     *     ENTITY?:DocumentType,
+     *     DOCUMENT_ID?:int,
+     *     ACTIVITY: WorkflowTaskActivityType,
+     *     PARAMETERS?:array,
+     *     DOCUMENT_URL?:string } $filter
+     * @param array|array{
+     *     'ID',
+     *     'WORKFLOW_ID',
+     *     'DOCUMENT_NAME',
+     *     'NAME',
+     *     'DESCRIPTION',
+     *     'MODIFIED',
+     *     'WORKFLOW_STARTED',
+     *     'WORKFLOW_STARTED_BY',
+     *     'OVERDUE_DATE',
+     *     'WORKFLOW_TEMPLATE_ID',
+     *     'WORKFLOW_TEMPLATE_NAME',
+     *     'WORKFLOW_STATE',
+     *     'STATUS',
+     *     'USER_ID',
+     *     'USER_STATUS',
+     *     'MODULE_ID',
+     *     'ENTITY',
+     *     'DOCUMENT_ID',
+     *     'ACTIVITY',
+     *     'PARAMETERS',
+     *     'DOCUMENT_URL' } $select
      * @return WorkflowTasksResult
      * @throws BaseException
      * @throws TransportException
@@ -49,7 +91,7 @@ public function __construct(
     public function list(
         array $order = ['ID' => 'DESC'],
         array $filter = [],
-        array $select = ['ID', 'WORKFLOW_ID', 'DOCUMENT_NAME', 'NAME'])
+        array $select = ['ID', 'WORKFLOW_ID', 'DOCUMENT_NAME', 'NAME']): WorkflowTasksResult
     {
         return new WorkflowTasksResult($this->core->call('bizproc.task.list', [
             'SELECT' => $select,