Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added trademark in footer #1736

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Added trademark in footer #1736

wants to merge 9 commits into from

Conversation

psankhe28
Copy link
Contributor

Description

This PR fixes #1622

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Prati28 <sankhepratiksha3@gmail.com>
Copy link

netlify bot commented May 2, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 96780e9
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6633e5977a48c70008cd7e58
😎 Deploy Preview https://deploy-preview-1736--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 2, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 39c77c4
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6642014cff7995000896a20e
😎 Deploy Preview https://deploy-preview-1736--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vishalvivekm
Copy link
Member

Revert formatting and prettier changes, if you would. @psankhe28

@vishalvivekm
Copy link
Member

@psankhe28 Let's discuss this on Websites's call.
Add this as an agenda item into the meeting minutes, if you would :)

Signed-off-by: Prati28 <sankhepratiksha3@gmail.com>
Signed-off-by: Prati28 <sankhepratiksha3@gmail.com>
Signed-off-by: Prati28 <sankhepratiksha3@gmail.com>
@Rexford74
Copy link

Hey, Pratiksha. I've taken a look at the deployment. I think that just having the word 'Trademarks' there seems a little vague. Is it possible to have something like what is implemented here as this has been confirmed to be the desired result by the issue raiser?
Then you can make the 'Trademarks Usage Page' a clickable link that leads to the usage webpage. Let me know what you think. Thanks.

@psankhe28
Copy link
Contributor Author

Hey, Pratiksha. I've taken a look at the deployment. I think that just having the word 'Trademarks' there seems a little vague. Is it possible to have something like what is implemented here as this has been confirmed to be the desired result by the issue raiser? Then you can make the 'Trademarks Usage Page' a clickable link that leads to the usage webpage. Let me know what you think. Thanks.

In the Slack channel, I inquired about which implementation to pursue, and based on the suggestions, I was advised to implement the one you can observe in the pull request.

@Rexford74
Copy link

Rexford74 commented May 13, 2024

But it seems too vague. It says 'Trademarks' but doesn't specify for which solution, or that it is a disclaimer either. It just links people to the LFX usage page. I don't know that this is a better outcome than the one sampled in the initial issue. If it's possible, I'll also like to see the link to the conversation that you had on slack so that I can get a bit more insight on the conversation had.
That said, in the meantime, maybe we can merge this PR to allow for traction, then when more clarity is achieved, we can make improvements where necessary.

@psankhe28
Copy link
Contributor Author

But it seems too vague. It says 'Trademarks' but doesn't specify for which solution, or that it is a disclaimer either. It just links people to the LFX usage page. I don't know that this is a better outcome than the one sampled in the initial issue. If it's possible, I'll also like to see the link to the conversation that you had on slack so that I can get a bit more insight on the conversation had. That said, in the meantime, maybe we can merge this PR to allow for traction, then when more clarity is achieved, we can make improvements where necessary.

https://layer5io.slack.com/archives/C015QJKUMPU/p1714659786470789

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website does not have the correct trademark disclaimer
3 participants