Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted div length to ensure equal height in modal #1702

Closed
wants to merge 1 commit into from

Conversation

ayush844
Copy link

@ayush844 ayush844 commented Apr 6, 2024

Description

This PR fixes #1637

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

netlify bot commented Apr 6, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 407ef5d
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/661138945cbcd5000820e9cf
😎 Deploy Preview https://deploy-preview-1702--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: ayush844 <ayush.xyz1625@gmail.com>
@ayush844
Copy link
Author

ayush844 commented Apr 6, 2024

here the modal is working fine when we zoom out by any amount and zoom in till (125 - 130%)

Screenshot from 2024-04-06 17-47-35

also both the paragraph are truncated after 3 lines, so extra content should not cause any issue

@vishalvivekm
Copy link
Member

@ayush844 Let's discuss this on websites call. Add this as an agenda item to the meeting minutes, if you would :)

Copy link
Member

@abhishekmmgn abhishekmmgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ayush for your 1st time contribution.
Apparently, I've fixed this issue in a previous PR. Though it has not been merged yet.
#1705

Copy link

stale bot commented May 15, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label May 15, 2024
@iArchitSharma
Copy link
Contributor

Hi @ayush844 since this is already fixed, I am closing this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website issue/stale Issue has not had any activity for an extended period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Catalog] Inconsistent Background Color in Pop-up: Left Side Does Not Extend to Full Height
4 participants