Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds graphql resolve info to loader ts definition #917

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: adds graphql resolve info to loader ts definition #917

wants to merge 2 commits into from

Conversation

dsoffiantini
Copy link

Adds info object into loader definition, as a loader with disabled caching will provide the info object

mcollina
mcollina requested changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for these typeS?

@dsoffiantini
Copy link
Author

Can you add a test for these typeS?

@mcollina Added!

mcollina
mcollina approved these changes Nov 20, 2022
View reviewed changes
Copy link
Collaborator

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Collaborator

mcollina commented Dec 5, 2022

CI is failing, can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dsoffiantini @mcollina