feat: improve scan and implement falsePositives #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@tvcsantos Unfortunately I have much parallel tasks to do at the moment and it will still take some time until #2864 is finally done. When I am done with it, I would inform you inside the PR about further steps. |
|
@de-jcup Yup all good on my side 👍 . Feel free to ping me afterwards. |
tvcsantos
force-pushed
the
feature/add-falsePositives-improve-scan
branch
from
36e9260
to
c064054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for false positives on GitHub actions by implementing
falsePositivesaction. This action works for the following SecHub CLI actions:defineFalsePositiveswith inputactionspecified asDEFINE.markFalsePositiveswith inputactionspecified asMARK.unmarkFalsePositiveswith inputactionspecified asUNMARK.This PR also improves and fixes
scanaction to be fully working with the latest client version. PreviousgetReportwas failing sincegetReportdoes not support the additional input--reportformat. According to documentationgetReporton CLI always outputs in JSON. This PR fixes that.In addition also improved CLI binaries release download by using GitHub tool cache, so that we can download and cache the tool in runners.
Closes: #2078