Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete base image definition #2502 #2517

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

sven-dmlr
Copy link
Member

Copy link
Member

@Jeeppler Jeeppler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not sufficient. It will most likely break the local start of PDS-Solutions. The local development workflow and local system testing is, to start the PDS solution via wrapper script 01-start… or 05-start…. Both scripts take the base image information from: https://github.com/mercedes-benz/sechub/blob/develop/sechub-pds-solutions/shared/environment/env-base-image. And create a .env and .env-single with all the default values. Please ensure, that each 01-start… und 05-start… scripts contain the line setup_environment_file ".env" "env" "$ENVIRONMENT_FILES_FOLDER/env-base-image" (source: https://github.com/mercedes-benz/sechub/blob/develop/sechub-pds-solutions/gosec)/01-start-single-docker-compose.sh#L12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pds-solutions: remove redundancy in base image definition
2 participants