Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pds-solutions: remove redundancy in base image definition #2502

Open
sven-dmlr opened this issue Aug 21, 2023 · 2 comments · May be fixed by #2517
Open

pds-solutions: remove redundancy in base image definition #2502

sven-dmlr opened this issue Aug 21, 2023 · 2 comments · May be fixed by #2517
Labels
build release

Comments

@sven-dmlr
Copy link
Member

Situation

Currently each pds solution contains an env file containing this line:

BASE_IMAGE="ghcr.io/mercedes-benz/sechub/pds-base"

This redundancy should be removed.

ToDo

  • source sechub-pds-solutions/shared/environment/env-base-image in release builds before the above env file
  • remove the BASE_IMAGE information from the env file of every pds-solution
@sven-dmlr sven-dmlr added this to the PDS 1.2.0 milestone Aug 21, 2023
@sven-dmlr sven-dmlr self-assigned this Aug 21, 2023
@sven-dmlr sven-dmlr mentioned this issue Aug 21, 2023
Merged
sven-dmlr added a commit that referenced this issue Aug 24, 2023
@sven-dmlr
remove obsolete base image definition #2502
89bdbce
@sven-dmlr
Copy link
Member Author

sven-dmlr commented Aug 24, 2023 •
edited

Checked in detail and found out that in the gh-action the BASE_IMAGE variable is not taken from env file:

export BASE_IMAGE="${ACTIONS_SECHUB_REGISTRY}/pds-base:${PDS_VERSION}"

So we can safely remove the above code.

@sven-dmlr sven-dmlr linked a pull request Aug 24, 2023 that will close this issue
Open
@sven-dmlr
Copy link
Member Author

sven-dmlr commented Aug 25, 2023 •
edited

This issue needs more testing and probably follow-up changes.
See comment #2517 (review)

-> Somebody else can work on this issue.

@sven-dmlr sven-dmlr removed their assignment Aug 25, 2023
@sven-dmlr sven-dmlr modified the milestones: PDS 1.2.0, PDS 1.3.0 Nov 24, 2023
@sven-dmlr sven-dmlr modified the milestones: PDS 1.3.0, PDS 1.4.0 Jan 4, 2024
@sven-dmlr sven-dmlr removed this from the PDS 1.4.0 milestone Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove obsolete base image definition #2502 mercedes-benz/sechub
1 participant
@sven-dmlr