New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce iterations to two #16
base: main
Are you sure you want to change the base?
Conversation
This will allow us to generate different stacks for different apps
Bizarrely, this is still outputting 3 matches for me, even after a clean build of the app. Your build evidently is working correctly though, based on the screenshot. Before we merge this, I think we should make this an extra screen and a selectable option. |
Let's make sure it's working for you first. You'll need to set an environment variable for this to work. The easiest way to do this is probably through the Dockerfile - I can add something to the readme. The reason I've got the screenshot is because I deployed the whole thing into AWS with the environment variable set to two - that's what 96f1330 does |
This allows users running the system locally with docker-compose to alter the number of matches they want
@johnpeart try with the new commit on this branch, and change the |
No dice. I've tried:
😕 |
e861043
to
c9ae677
Compare
Definitely the right branch, so it's clearly something weird with my set up. Running So it must be the right files; just building the wrong outputs. |
I've done my best to make this flexible by passing the number of iterations as an environment variable. That means that, if we want to deploy this code for anyone else, we can create a new
Stack
object with a different number of iterationsI would also point out that, if users only want two iterations instead of the usual three, they could simply...not use the last set.