Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(data-widget): move three state checkbox style to atlas core #900

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(data-widget): move three state checkbox style to atlas core #900

wants to merge 1 commit into from

Conversation

gjulivan
Copy link
Contributor

@gjulivan gjulivan commented Jan 22, 2024 •
edited

move three state checkbox to plugin-component-kit
and styling will be handled by atlas core (mendix/atlas#121)

this allow easier maintenance and consistencies along checkboxes usage

@gjulivan gjulivan requested a review from a team as a code owner January 22, 2024 14:10
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2024 •
edited

Sigrid maintainability feedback

💭️ You did not change any files that are measured by Sigrid

Sigrid compared your code against the baseline of 2024-01-22.

@gjulivan gjulivan mentioned this pull request Jan 22, 2024
Open
iobuhov
iobuhov reviewed Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@iobuhov iobuhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed ThreeStateCheckBox? Or you moved it? I don't see component code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iobuhov iobuhov iobuhov approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
data-widgets shared
Projects
None yet
Milestone
No milestone
2 participants
@gjulivan @iobuhov