-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WC-1619]: Combobox lazy load option #1075
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelreichert
force-pushed
the
feat/WC-1619-combobox-lazy-load-option
branch
2 times, most recently
from
May 15, 2024 13:31
0d2e793
to
41ea7b5
Compare
gjulivan
reviewed
May 15, 2024
packages/pluggableWidgets/combobox-web/src/helpers/Association/BaseAssociationSelector.ts
Outdated
Show resolved
Hide resolved
gjulivan
reviewed
May 15, 2024
packages/pluggableWidgets/combobox-web/src/helpers/Database/DatabaseSingleSelector.ts
Outdated
Show resolved
Hide resolved
gjulivan
previously approved these changes
May 16, 2024
samuelreichert
force-pushed
the
feat/WC-1619-combobox-lazy-load-option
branch
from
May 16, 2024 10:52
53cf2e1
to
0408ec5
Compare
leonardomendix
approved these changes
May 16, 2024
gjulivan
approved these changes
May 16, 2024
samuelreichert
force-pushed
the
feat/WC-1619-combobox-lazy-load-option
branch
from
May 17, 2024 09:04
0408ec5
to
12582f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
New feature (non-breaking change which adds functionality)
Description
Add new property
lazyLoading
for association and database source, with default value set to false.When set to true, only a set of data is loaded in the beginning, and the rest will be loaded when scrolling to the bottom.
There are no visual changes, all visual changes will be implemented in another PR.