[WC-2469] Fix dg2 in modern client #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0b1n
changed the title
gjulivan
previously approved these changes
Apr 30, 2024
|
Should we open a PR to |
r0b1n
force-pushed
the
fix/dg2-modern-client
branch
from
1027c70
to
c36d8ae
Compare
1. Patch mobx to isolate its global store. In modern client setup, calling
config() to isolate is not enough, this happens too late and gives an error.
Hence the fix is to use separate namespace for mobx globals (patch out version).
2. Patch mobx-react-lite to prevent usage of use-sync-external-store shim.
This shim is causing issues with modern client as it uses `require("react")`
which is not processed at this point and fails in runtime.
iobuhov
force-pushed
the
fix/dg2-modern-client
branch
from
c36d8ae
to
259501b
Compare
iobuhov
approved these changes
May 15, 2024
leonardomendix
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.