Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine/Coarse Location Permission Checking for Request Location Permission #72

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

skullquake
Copy link

Added Fine/Coarse location permission checking to native-widgets/packages/jsActions/nanoflow-actions-native/src/RequestLocationPermission.ts

Checklist

  • Contains unit tests ✅ ❌
  • Contains breaking changes ✅ ❌
  • Compatible with: MX 7️⃣, 8️⃣, 9️⃣
  • Did you update version and changelog? ✅ ❌
  • PR title properly formatted ([XX-000]: description)? ✅ ❌
  • Works in Android ✅ ❌
  • Works in iOS ✅ ❌
  • Works in Tablet ✅ ❌

Feature specific

  • Comply with designs ✅ ❌
  • Comply with PM's requirements ✅ ❌

Please remove unnecessary emojis and sections and this comment before proceeding

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

...

Relevant changes

Please add a high level explanation of what was changed and how the initial problem was solved

What should be covered while testing?

...

Extra comments (optional)

Please add extra comments or delete the section if not required

skullquake and others added 3 commits August 14, 2023 23:01
Include check for reactNativeModule.PermissionsAndroid.PERMISSIONS.ACCESS_COARSE_LOCATION;
Signed-off-by: Ockert van Schalkwyk <ockert.vanschalkwyk@entidad.io>
@skullquake skullquake requested a review from a team as a code owner August 23, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants