Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOO-1361] Add check and request EXACT_ALARM_PERMISSION to RequestGenericPermission (9.24) #138

Merged
merged 4 commits into from
May 28, 2024

Conversation

PaulHryn
Copy link
Contributor

@PaulHryn PaulHryn commented May 1, 2024

Checklist

  • Contains unit tests ❌
  • Contains breaking changes ✅
  • Compatible with: MX 9️⃣
  • Did you update version and changelog? ❌
  • PR title properly formatted ([XX-000]: description)? ✅
  • Works in Android ✅
  • Works in iOS ❌
  • Works in Tablet ❌

Feature specific

  • Comply with designs ✅
  • Comply with PM's requirements ✅

This PR contains

  • Feature
  • Documentation

Relevant changes

I've added check and request EXACT_ALARM_PERMISSION to RequestGenericPermission. Current version of "react-native-permission" doesnt support SCHEDULE_EXACT_ALARM for Android, so I've added it using another library and combined with already existing functions. This permission is enabled by default on Android API SDK <= 33, but targeting 34 (Android 14) it's became disabled. To ensure that local notifications will work on Android 14, we have to add manual permission request.

@PaulHryn PaulHryn self-assigned this May 1, 2024
@PaulHryn PaulHryn requested a review from a team as a code owner May 1, 2024 08:05
@moo-team moo-team added the Widget label May 1, 2024
@Ahmad-Elsayed
Copy link
Contributor

We will need to add checkGenericPermission JsAciton, it should include the check part from the request generic permission action. This will help users to check for specific permissions without requesting them.

@PaulHryn PaulHryn changed the title [MOO-1361] Add check and request EXACT_ALARM_PERMISSION to RequestGenericPermission [MOO-1361] Add check and request EXACT_ALARM_PERMISSION to RequestGenericPermission (9.24) May 7, 2024
@PaulHryn PaulHryn merged commit 85aba45 into lts/mx/9.24 May 28, 2024
4 checks passed
@PaulHryn PaulHryn deleted the moo/MOO-1361-schedule-exact-alarm-9-24 branch May 28, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants