-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MOO-1361] Add check and request EXACT_ALARM_PERMISSION to RequestGenericPermission #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadymv-mendix
previously approved these changes
May 1, 2024
furkanarabaci
requested changes
May 27, 2024
vadymv-mendix
approved these changes
May 27, 2024
NikolaSimsic
approved these changes
May 27, 2024
furkanarabaci
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added check and request EXACT_ALARM_PERMISSION to RequestGenericPermission. Current version of "react-native-permission" doesnt support SCHEDULE_EXACT_ALARM for Android, so I've added it using another library and combined with already existing functions. This permission is enabled by default on Android API SDK <= 33, but targeting 34 (Android 14) it's became disabled. To ensure that local notifications will work on Android 14, we have to add manual permission request.