Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery Scroll Indicator #121

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

david-archway
Copy link

@david-archway david-archway commented Mar 11, 2024

Add the ability to hide the scroll indicator.

Checklist

  • Contains unit tests ❌
  • Contains breaking changes ❌
  • Compatible with: MX 7️⃣, 8️⃣, 9️⃣
  • Did you update version and changelog? ❌
  • Works in Android ✅
  • Works in iOS ✅
  • Works in Tablet ✅

This PR contains

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Other (describe)

What is the purpose of this PR?

This PR adds the ability to hide the scroll indicators on the gallery widget.

Relevant changes

Add a property to the widget to determine if the scroll indicators should show. The underlying list view already supports this functionality, so that property just gets passed to the widget.

What should be covered while testing?

The default value is set to false so that it's backwards compatible.

@david-archway david-archway requested a review from a team as a code owner March 11, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants