Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aws cli to sync with S3 #2027

Merged
merged 5 commits into from May 13, 2024
Merged

Use aws cli to sync with S3 #2027

merged 5 commits into from May 13, 2024

Conversation

MarkoBarisic
Copy link
Contributor

@MarkoBarisic MarkoBarisic commented May 10, 2024

Description

This PR changes how we upload data to S3. We won't use the jakejarvis/s3-sync-action any more because it works only on linux and strange is macOS. We will now use aws cli.

This PR also removes the upload_to_s3.yaml workflow because it is deprecated.

CI Testing Labels

Please select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone

@MarkoBarisic MarkoBarisic added the Docs unnecessary Docs unnecessary label May 10, 2024
@MarkoBarisic MarkoBarisic added this to the mg-v2.16.1 milestone May 10, 2024
@MarkoBarisic MarkoBarisic self-assigned this May 10, 2024
@MarkoBarisic MarkoBarisic changed the title Switch to aws cli to sync with S3 Use aws cli to sync with S3 May 10, 2024
@MarkoBarisic MarkoBarisic marked this pull request as ready for review May 10, 2024 13:42
Copy link
Contributor

@hal-eisen-MG hal-eisen-MG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkoBarisic MarkoBarisic added this pull request to the merge queue May 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 10, 2024
@MarkoBarisic MarkoBarisic added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
@MarkoBarisic MarkoBarisic added this pull request to the merge queue May 13, 2024
Merged via the queue into master with commit 100e53e May 13, 2024
10 checks passed
@MarkoBarisic MarkoBarisic deleted the CI-fix-s3-upload branch May 13, 2024 06:41
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

MarkoBarisic added a commit that referenced this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs unnecessary Docs unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants