Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Wrong assert in recovery process test #2019

Merged
merged 2 commits into from May 21, 2024
Merged

Fix: Wrong assert in recovery process test #2019

merged 2 commits into from May 21, 2024

Conversation

antoniofilipovic
Copy link
Collaborator

Description

This diff fixes the test for replica recovery. Test has assert that replica should be in recovery mode first, but due to threads scheduling replica can recover before test gets to this part

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • Fix wrong assert in recovery process test

CI Testing Labels

Please select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • No release note needed
  • Link the documentation PR here
    • Docs not needed
  • Tag someone from docs team in the comments

@antoniofilipovic antoniofilipovic added tests Docs unnecessary Docs unnecessary CI -build=release -test=core Run release build and core tests on push labels May 9, 2024
@antoniofilipovic antoniofilipovic added this to the mg-v2.17.0 milestone May 9, 2024
@antoniofilipovic antoniofilipovic self-assigned this May 9, 2024
@antoniofilipovic antoniofilipovic added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 15, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MarkoBarisic MarkoBarisic added this pull request to the merge queue May 21, 2024
Merged via the queue into master with commit d6e9ebf May 21, 2024
11 checks passed
@MarkoBarisic MarkoBarisic deleted the fix-recover-replica-test-wrong-assert branch May 21, 2024 08:15
MarkoBarisic pushed a commit that referenced this pull request May 21, 2024
@antoniofilipovic @gitbuda @MarkoBarisic
Fix: Wrong assert in recovery process test (#2019)
d131b1a 
Co-authored-by: Marko Budiselić <marko.budiselic@memgraph.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ignition Ignition Ignition approved these changes

Assignees

@antoniofilipovic antoniofilipovic

Labels
CI -build=release -test=core Run release build and core tests on push Docs unnecessary Docs unnecessary tests
Projects
None yet
Milestone
mg-v2.17.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@antoniofilipovic @Ignition @MarkoBarisic @gitbuda