New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Memgraph's startup process #2017
Conversation
22c117c
to
13d41b2
Compare
858afa0
to
007557b
Compare
@kgolubic RN is above, not sure if docs needed. |
04ad636
to
29d871a
Compare
29d871a
to
ebd4ddc
Compare
Quality Gate passedIssues Measures |
@kgolubic RN: The Bolt server needs mapping to its port otherwise server won't start, metrics server and websocket server can have silent fail. |
@antoniofilipovic I will use this as RN: Memgraph will now fail to start if the Bolt server cannot be created, ensuring a dedicated port is available. Failures in creating the WebSocket and HTTP servers will no longer crash Memgraph but will be logged more effectively. If the WebSocket server fails, the |
Description
From now on:
The Bolt server asserts (and server stops) if it can't get started as Memgraph instance must have a dedicated port for the bolt server. Silent fail around HTTP (metrics) and WebSocket servers are still permissible, but better logged
This diff applies changes from hypothesis testing from these two PRs:
to increase high-availability logging verbosity in e2e tests and wrap-around bolt server, websocket server and HTTP server ASSERTs so we are certain on which part has test failed.
Currently, there are a lot of silent fails, and no logging.
LoggerSink
won't be added to WSS if failure happened. If creating auth folder failed, Memgraph's initialization will be stopped.[master < Task] PR
CI Testing Labels
Please select the appropriate CI test labels (CI -build=build-name -test=test-suite)
Documentation checklist
LoggerSink
won't be added to it. Memgraph will crash if authentication folder cannot be created.