Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HA bank test #2012

Merged
merged 10 commits into from May 24, 2024
Merged

Add HA bank test #2012

merged 10 commits into from May 24, 2024

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented May 8, 2024

Description

  • In bank test, if transfer fails, descriptive log message is returned in order to make debugging easier.
  • Bolt+routing is removed from tests since it wasn't functional.
  • Invoke action register is renamed to initialize for HA tests.
  • Added HA bank test:
    • The test is run with fsync set to 1 (same as replication bank test)
    • Config is same as bank test (but can be tuned)
    • Only bolt connections are used
    • Cluster initialization is done on random coordinator
    • if registering/adding instance fails, the process will be continued and other instances might still get registered/added
    • all ServiceUnavailableExceptions are caught (they occur when trying to connect to instance which is down) -> similar thing should be done for other tests
    • checker checks same things as in HA empty test + checks from bank test + it checks that there are no failed initializations, no failed read balances and no failed show instances

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • Add HA bank test

CI Testing Labels

Please select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@as51340 as51340 added the CI -build=jepsen -test=core Run jepsen build and core tests on push label May 8, 2024
@as51340 as51340 changed the title Refactor bank test Add HA bank test May 8, 2024
@as51340 as51340 force-pushed the add-jepsen-bank-test branch 4 times, most recently from 2a7fc48 to 904b1e0 Compare May 8, 2024 11:37
@as51340 as51340 added this to the mg-v2.18.0 milestone May 20, 2024
@as51340 as51340 force-pushed the add-jepsen-bank-test branch 5 times, most recently from e5598c4 to c46fcef Compare May 23, 2024 11:40
@as51340 as51340 marked this pull request as ready for review May 23, 2024 11:51
@as51340 as51340 requested a review from Ignition May 23, 2024 11:52
@as51340 as51340 self-assigned this May 23, 2024
@as51340 as51340 added tests Docs unnecessary Docs unnecessary feature feature labels May 23, 2024
@as51340
Copy link
Contributor Author

as51340 commented May 23, 2024

@kgolubic improvements on the test side, RN not needed

Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@as51340 as51340 added this pull request to the merge queue May 24, 2024
Merged via the queue into master with commit d4973d0 May 24, 2024
11 checks passed
@as51340 as51340 deleted the add-jepsen-bank-test branch May 24, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI -build=jepsen -test=core Run jepsen build and core tests on push Docs unnecessary Docs unnecessary feature feature tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants