Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter embedding after Cartesian operator #1924

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Filter embedding after Cartesian operator #1924

wants to merge 4 commits into from

Conversation

andrejtonev
Copy link
Contributor

@andrejtonev andrejtonev commented Apr 9, 2024 •
edited

Description

Filters can get embedded into index scans.
In cases where a filter in after a Cartesian, we need to substitute the Cartesian for a Join.
This PR fixes a particular case where that substitution was not performed.

closes #1648

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • [FINAL GIT MESSAGE]

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@andrejtonev andrejtonev self-assigned this May 20, 2024
@andrejtonev andrejtonev added Docs - changelog only Docs - changelog only CI -build=community -test=core Run community build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push labels May 20, 2024
@andrejtonev andrejtonev added CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push and removed CI -build=debug -test=core Run debug build and core tests on push CI -build=community -test=core Run community build and core tests on push labels May 22, 2024
@andrejtonev andrejtonev requested a review from Ignition May 23, 2024 10:20
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@andrejtonev andrejtonev marked this pull request as ready for review May 23, 2024 14:16
@andrejtonev andrejtonev added this to the mg-v2.18.0 milestone May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josipmrden Josipmrden Awaiting requested review from Josipmrden

@Ignition Ignition Awaiting requested review from Ignition

At least 1 approving review is required to merge this pull request.

Assignees

@andrejtonev andrejtonev

Labels
CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=benchmark Run release build and benchmark on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push Docs - changelog only Docs - changelog only
Projects
None yet
Milestone
mg-v2.18.0
Development

Successfully merging this pull request may close these issues.

Cartesian product + Index cause wrong result
1 participant
@andrejtonev