Allow user to connect without database #1884
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignition
reviewed
Apr 8, 2024
| @@ -121,9 +122,14 @@ void MultiDatabaseAuth(memgraph::query::QueryUserOrRole *user, std::string_view | |||
| namespace memgraph::glue { | |||
|
|
|||
| #ifdef MG_ENTERPRISE | |||
| std::string SessionHL::GetDefaultDB() { | |||
| std::optional<std::string> SessionHL::GetDefaultDB() { | |||
There was a problem hiding this comment.
Future change: do we want stronger default DB? name + uuid
There was a problem hiding this comment.
That makes sense.
I will implement this now, since we missed the 2.17 release.
| expected.append(", ".join(details)) | ||
| execute_checker(checker_binary, expected) | ||
| print("\033[1;36m~~ Finished permissions test ~~\033[0m\n") | ||
| # # Run the test with all combinations of permissions |
There was a problem hiding this comment.
Is this bring removed or updated?
andrejtonev
added
Docs needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to connect without a database defined.
If a user has a default db, the user will connect to that database.
If a user does not have a default db, we will connect without a database defined. Only db-less queries should be allowed.
If a user defines the database via the client, we will use the same logic as above, but each query will be executed against the user-defined db. Multi-tenant auth will be executed at first query execution.
Q: Should we allow multi-tenant queries (ex:
USE DATABASE x) even without db? YESBugfix: Was not updating the explicit flag when user explicitly defines the same database as the current one. This would in turn allow db switching, which is prohibited if user connects via
mgclient.connect(database="db", ...)[master < Task] PR
Documentation checklist