Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare multiple vendors locally #1873

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

Conversation

imilinovic
Copy link
Contributor

Description

Please briefly explain the changes you made here.

Please delete either the [master < EPIC] or [master < Task] part, depending on what are your needs.

[master < Epic] PR

  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message
    • [FINAL GIT MESSAGE]

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • [FINAL GIT MESSAGE]

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@imilinovic imilinovic self-assigned this Mar 27, 2024
@imilinovic imilinovic added the benchmarking mgBench and benchmarking Memgraph label Mar 27, 2024
Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@imilinovic imilinovic added this to the mg-v2.17.0 milestone Apr 11, 2024
@imilinovic imilinovic added the Docs unnecessary Docs unnecessary label Apr 11, 2024
@gitbuda gitbuda removed this from the mg-v2.17.0 milestone May 20, 2024
@gitbuda
Copy link
Member

gitbuda commented May 20, 2024

@imilinovic Removing this from the v2.17.0 milestone because it won't end up there. It's not put in v2.18.0 because it's not critical to be there -> maybe we can even close this PR (if mgbench is in a good state)?

@imilinovic
Copy link
Contributor Author

This has some useful stuff for local mgbench usage but we paused it to not mess with benchmarks since we discovered a few new issues on them at the time (and new release cycle came). I think its worth keeping, I just need to polish it a bit. Not a priority for sure @gitbuda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarking mgBench and benchmarking Memgraph Docs unnecessary Docs unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants