Adjust Parameter conflict criteria #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charjr
force-pushed
the
fix-style-conflict-check
branch
from
0474b86
to
e5cd7f5
Compare
carnage
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of OpenAPI-Specification #3737
spaceDelimitedandpipeDelimitedshould not conflict in most cases as they will have their parameter names stated first, i.e.tags=cat%20shorthair%20calicotags=cat|shorthair|calicoI also added a stricter requirement on
deepObjectto invalidate an api for allowing it to be anything other thanobject. This is because it does not make sense to use it for anything else and you cannot pick a "backup style" so how would we resolve it?I've left
spaceDelimitedandpipeDelimitedprimitives as "acceptable" since, though not technically valid, it would look identical totype:arraywith one item in it.