Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ViewPropType is depreciated #943

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ram33z
Copy link

@ram33z ram33z commented Sep 7, 2022

Platforms affected

What does this PR do?

ViewPropType is depreciated from react-native and is not supported directly. This fix implements deprecated-react-native-prop-types package to import ViewPropType wherever required.

What testing has been done on this change?

Locally, also implemented in react-native app and tested via an expo go platform.

Tested features checklist

@jkester1986
Copy link

would love to see this merged, we use this package but ViewPropTypes is no longer supported in the latest version of RN and the deprecated package needs to be used now

@abbasldn
Copy link

I've made these changes on my local machine as well. Hoping they merge this PR

@Jeith
Copy link

Jeith commented Sep 21, 2022

Hoping to see a merge soon - this is a major problem within our app

@DanielATm
Copy link

Changes are working perfectly, so hope soon to get merged.

@Jeith
Copy link

Jeith commented Oct 4, 2022

Any chance we'll see this merged @Anthony-Buisson @bd-arc ? These changes are working great on my side. Would love to have these changes in the npm package

@LG1710
Copy link

LG1710 commented Jan 13, 2023

Hello, could you merge this PR soon to use in a new tagged version, thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants