Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deprecate-react-native-prop-types #917

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apfritts
Copy link

@apfritts apfritts commented Apr 8, 2022

Platforms affected

All

What does this PR do?

RN 0.68 has deprecated and will eventually remove ViewPropTypes (see post). This adds the deprecated-react-native-prop-types package and uses that instead.

What testing has been done on this change?

Local testing, to ensure the deprecation warning has been removed.

Tested features checklist

@cameronnapoli
Copy link

+1

@farkmarnum
Copy link

Can confirm this branch removes the warnings when I tested.

@losh11
Copy link

losh11 commented May 25, 2022

Last August a similar PR was opened removing React proptypes. I believe this library is no longer being maintained, and has not received any update in over a year. I hope really popular react-native libraries are instead moved over to @react-community to maintain instead.

@mihneasuper
Copy link

any chance to get merged?

@easton36
Copy link

I think this repo is dead

@BrodaNoel
Copy link

@bd-arc could you please take a look at this some minutes?
We kind of have a problem here... This change is important. All the Expo users can't migrate to the new Expo SDK version because of this and some other small issues.

Please, consider taking a look at some PRs, or giving some Admin permissions to some trusted users.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants