Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ft/deployment setup #66

Merged
merged 68 commits into from
May 24, 2024
Merged

Ft/deployment setup #66

merged 68 commits into from
May 24, 2024

Conversation

thepsalmist
Copy link
Collaborator

This PR creates a workflow to deploy the news-search-api separately from the story-indexer.
Define workflow to deploy to staging & production

@thepsalmist thepsalmist self-assigned this Mar 27, 2024
@thepsalmist thepsalmist marked this pull request as ready for review April 3, 2024 07:03
@thepsalmist
Copy link
Collaborator Author

PS: We setting the SENTRY_DSN in the private story_indexer repo?

.github/workflows/docker-release.yml Outdated Show resolved Hide resolved
.github/workflows/docker-release.yml Outdated Show resolved Hide resolved
deploy.sh Show resolved Hide resolved
.github/workflows/docker-release.yml Outdated Show resolved Hide resolved
deploy.sh Show resolved Hide resolved
deploy.sh Outdated Show resolved Hide resolved
deploy.sh Outdated Show resolved Hide resolved
deploy.sh Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved
@philbudne
Copy link

philbudne commented Apr 8, 2024 via email

deploy.sh Show resolved Hide resolved
.github/workflows/docker-release.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link

@philbudne philbudne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. While I have remaining issues/questions (which could take an hour to fully write up), it's already taken too long to get to this point, and past experience has shown that in a week it's unlikely to be more than 50% better than the week before.

@thepsalmist
Copy link
Collaborator Author

@kilemensi you can have a final review

Copy link
Contributor

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

README.md Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
deploy.sh Outdated Show resolved Hide resolved
deploy.sh Outdated Show resolved Hide resolved
docs/deployment.md Show resolved Hide resolved
docs/deployment.md Outdated Show resolved Hide resolved
docs/deployment.md Outdated Show resolved Hide resolved
docs/deployment.md Outdated Show resolved Hide resolved
deploy.sh Outdated Show resolved Hide resolved
thepsalmist and others added 13 commits May 24, 2024 09:27
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Co-authored-by: Clemence Kyara <kilemensi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants