Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate list-cookies extension to manifest version 3 #559

Closed
wants to merge 1 commit into from

Conversation

2-X
Copy link

@2-X 2-X commented Apr 25, 2024

Description

browser --> chrome
idk if this is an issue others run into but i assumed it was because of manifest v3

Motivation

Additional details

Related issues and pull requests

Copy link

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.

@2-X 2-X changed the title migrate extension to manifest version 3 migrate list-cookies extension to manifest version 3 Apr 25, 2024
@rebloor
Copy link
Collaborator

rebloor commented Apr 29, 2024

@2-X you haven't made any changes that migrate this to Manifest v3. That would start with a change to the manifest.json file line "manifest_version": 2. These examples are intended for firefox, hence they use the browser namespace. Were you running this example in Chrome?

@2-X 2-X closed this Apr 29, 2024
@2-X
Copy link
Author

2-X commented Apr 29, 2024

@rebloor thanks for the reply! yes i was running it in chrome, i see that browser is the firefox version of chrome API. something like this PR should instead be part of a larger refactor to make them all work on both chrome and firefox, if desired, so i closed this PR 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants