native-messaging: fix Windows checker script not to fail on missing HKCU when HKLM is set

[dahn-zk]

Description

from #557 :

this line will throw when you create required key in HKEY_LOCAL_MACHINE instead of HKEY_CURRENT_USER ( which is allowed ) , so this script should not behave like this :

webextensions-examples/native-messaging/check_config_win.py

Line 22 in faadfca

key = winreg.OpenKey(getattr(winreg, root), key_path)

also , as the script is in Python anyway , the whole thing can be simplified using for-else :

for root in key_roots:
    try:
        key = winreg.OpenKey(getattr(winreg, root), key_path)
        print('Checking:', root, key_path)
        res = winreg.QueryValueEx(key, '')
    except FileNotFoundError:
        continue
    break
else:
    raise ValueError('Could not find a registry entry, aborting.')

Motivation

i was bored

Additional details

update : ignore the following , i created a PR for that mdn/content#33211

btw , in the docs https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging#registry there is an incorrect info about registry keys . it says "two registry entries should be created for the messaging to work" as if "both" in HKEY_CURRENT_USER and HKEY_LOCAL_MACHINE . but this is not true . only one should be . here is the proof in the Firefox source code : https://searchfox.org/mozilla-central/source/toolkit/components/extensions/NativeManifests.sys.mjs#59-83

Related issues and pull requests

fixes #557

[github-actions]

It looks like this is your first pull request. 🎉 Thank you for your contribution! One of the project maintainers will triage and assign the pull request for review. We appreciate your patience. To safeguard the health of the project, please take a moment to read our code of conduct.