Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(simple-service-worker): avoid HTML to appear as text #234

Merged
merged 4 commits into from
Mar 7, 2024
Merged

fix(simple-service-worker): avoid HTML to appear as text #234

merged 4 commits into from
Mar 7, 2024

Conversation

Maximaximum
Copy link
Contributor

Fixes #191

@caugner caugner changed the title Fix #191 fix(simple-service-worker): avoid HTML to appear as text Oct 25, 2023
@Maximaximum @caugner
Update service-worker/simple-service-worker/app.js
b73e803 
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
@Maximaximum Maximaximum requested a review from a team as a code owner February 28, 2024 09:16
@Maximaximum Maximaximum requested review from pepelsbey and removed request for a team February 28, 2024 09:16
pepelsbey
pepelsbey approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@pepelsbey pepelsbey left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you both :)

@pepelsbey
Copy link
Contributor

@caugner what do you think?

@pepelsbey pepelsbey merged commit 9edd962 into mdn:main Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

@caugner caugner caugner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simple Service Worker example displays raw HTML
4 participants
@Maximaximum @pepelsbey @caugner @bsmth