Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing channel messaging type error #228

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixing channel messaging type error #228

wants to merge 3 commits into from

Conversation

marrionluaka
Copy link

Changes

  • Guards against the event ports when receiving a message from the main page.

Testing Procedure

  1. Visit /dom-examples/channel-messaging-basic/
  2. Instead of seeing this:
    Screen Shot 2023-09-19 at 4 46 49 PM
  3. You should see this:
    Screen Shot 2023-09-19 at 4 46 36 PM

@marrionluaka marrionluaka force-pushed the marrionluaka-fix-channel-messaging-type-error branch from aca3406 to 6d7d636 Compare September 21, 2023 20:50
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@marrionluaka marrionluaka requested a review from a team as a code owner May 10, 2024 16:14
@marrionluaka marrionluaka requested review from pepelsbey and removed request for a team May 10, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey Awaiting requested review from pepelsbey pepelsbey is a code owner automatically assigned from mdn/core-yari-content

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@marrionluaka