Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specifications and support information for the "size" attribute #23085

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jGowgiel
Copy link

Summary

The "size" attribute doesn't currently have any links, or support data. As an older, core property (introduced in the first version of the HTML spec - https://html.spec.whatwg.org/commit-snapshots/c9e804f04d03a0658bfa689cb0f368a4d2e37936/?C=M&O=A#the-size-attribute) I think it has probably just been overlooked so far.

The information on the "size" attribute page also doesn't align with the spec, which I am hoping to correct with a PR in the mdn/content repository. I'll add a link to this associated PR as a comment once I open this PR!

Test results and supporting details

I have verified my changes with npm test as instructed for this project.

Related issues

Partially fixes #18443.

@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label May 14, 2024
@jGowgiel
Copy link
Author

Associated mdn/content PR: mdn/content#33598

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label May 29, 2024
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@Elchi3
Copy link
Member

Elchi3 commented May 29, 2024

Thanks for your PR and sorry for the merge conflict. Can you resolve that?

I merged #21874 first which is the other half to fix #18443

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label May 29, 2024
@jGowgiel
Copy link
Author

Hey @Elchi3 - no worries at all! Fixed up those conflicts and just pushed the updated branch. Cheers, and thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

html.elements.attribute.size and html.elements.attributes.required are missing
2 participants