Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rel=noopener compat data for android webview #23076

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stefanjudis
Copy link
Contributor

Summary

This PR adds compat data for implicit rel=noopener on target=_blank links. The support info comes from chromestatus.

Test results and supporting details

I wasn't able to test it.

Related issues

@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label May 13, 2024
@myfonj
Copy link
Contributor

myfonj commented May 13, 2024

On recent Android 13 with in Twitter app that hopefully uses WebView (detected as "Chrome 124" by whatismybrowser.com) implicit noopener on target="_blank" works correctly; or more precisely navigating to test page https://myfonj.github.io/tst/implicit-noopener-test.html and clicking "no extra attr" produces page that reports "Opener: null".

Comment on lines 356 to 358
"webview_android": {
"version_added": false
"version_added": "88"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skyclouds2001 Fixed. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or not... sec. 🫣

Now hopefully. :)

@myfonj
Copy link
Contributor

myfonj commented May 13, 2024

It would be neat to have a proper test in some older (ideally "88") WebView version, confirming the "88 qualified guess". Or dig up some more authoritative relnotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants