Update public_class_fields for Safari #23054
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marks Safari 14-15 as having partial support for public class fields. While they do have a basic implementation, there is a critical bug which leads to exceptions in many cases. The exceptions are especially hard to identify/debug because they are resolved when dev-tools are open. The bug is resolved in Safari 16. References: - Safari bug: https://bugs.webkit.org/show_bug.cgi?id=236843 - `babel/babel` discussion regarding adding 'bugfix' behavior for this issue: babel/babel#14289
github-actions
bot
added
the
data:js 📟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Marks Safari 14-15 as having partial support for public class fields. While they do have a basic implementation, there is a critical bug which leads to exceptions in many cases. The exceptions are especially hard to identify/debug because they are resolved when dev-tools are open.
The bug is resolved in Safari 16.
Test results and supporting details
Safari bug: https://bugs.webkit.org/show_bug.cgi?id=236843
babel/babeldiscussion regarding adding 'bugfix' behavior for this issue: [Bug]: Safari class fields implementation is buggy - ReferenceError: Can't find variable babel/babel#14289