-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selection updates for parallel APIs ff125 #23013
Conversation
}, | ||
"status": { | ||
"experimental": true, | ||
"standard_track": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, spec only requires returning one range.
b63d80f
to
a9d8204
Compare
Hi @queengooborg, would it be possible for you to review this PR? |
Hi @dipikabh, this is on my review queue already. No need to ping me after marking me for review. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hamishwillee, looks reasonable to me. 👍
FF126 adds
Selection.getComposedRanges()
in nightly, but it also adds some updates to existing APIs:Selection.getComposedRanges()
Selection.setBaseAndExtent()
- this will now accept anchorNode and focusNode arguments that reside in different shadow trees, which will set the selection accordingly.Selection.collapse()
- can now accept a node in any tree, and will collapse the range to that Node.extend()
- This should work as-expected, even if the new focusNode is in a different shadow tree.There are other features coming but that is what is in now (according to https://bugzilla.mozilla.org/show_bug.cgi?id=1867058#c31)
FYI another thing that I don't know how to capture in BCD. I don' think I will:
Related work can be tracked in mdn/content#33180