Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarQube 10.5 compatibility #904

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

dkeitzel
Copy link

As far as I know this should be enough to produce a binary compatible plugin for SonarQube 10.5. See also #900 (comment).

@mc1arke
Copy link
Owner

mc1arke commented Apr 26, 2024

This change isn't actually required: we only need the Sonarqube build dependency to allow us to compile the plugin. Given 10.5 hasn't changed any of the APIs we use then there's nothing that we need to change; I just need to push docker images and update the README

@mc1arke mc1arke closed this Apr 26, 2024
@dkeitzel
Copy link
Author

Are you sure? I'm by no means an expert in Java binary compatibility 😅. But at least the return type of ProjectAlmSettingDao#insertOrUpdate changed.

@mc1arke
Copy link
Owner

mc1arke commented May 6, 2024

Are you sure? I'm by no means an expert in Java binary compatibility 😅. But at least the return type of ProjectAlmSettingDao#insertOrUpdate changed.

Sorry, I'd missed that change, and yes it will cause problems for anyone creating a new ALM setting. This means we'll need to create a release purely for 10.5 😞

@mc1arke mc1arke reopened this May 6, 2024
@tburschka
Copy link

Any news on this?

@zisuu
Copy link

zisuu commented May 24, 2024

would be nice to get this solved soon. We're currently having people that can't change some settings in their Projects due to this. Thanks a lot for your efforts 👍

@gjabouley-invn
Copy link

Hello
as usual for people in a hurry, SNAPSHOT version built from this PR can be downloaded using GitHub checks artefacts: https://github.com/mc1arke/sonarqube-community-branch-plugin/actions/runs/8969366962/artifacts/1476415257

@gjabouley-invn
Copy link

Are you sure? I'm by no means an expert in Java binary compatibility 😅. But at least the return type of ProjectAlmSettingDao#insertOrUpdate changed.

Sorry, I'd missed that change, and yes it will cause problems for anyone creating a new ALM setting. This means we'll need to create a release purely for 10.5 😞

You will probably need to build a new version for each new version of SQ, why not aligning the plugin version number with SQ version ? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants