Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ObstacleDistanceOverlay] Fix 90 degree offset #10879

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dakejahl
Copy link
Contributor

Fixes issue where obstacle distances are displayed with a +90 degree offset. This is due to an error in the coordinate system math along with an error in calculating the degrees for the current distance index. The yaw angle theta is measured CW from North and therefore r * cos(theta) is negative Y axis and r * sin(theta) is positive X.

Qt docs

The x values increase to the right and the y values increase downwards.
image

There's more still that needs to be done. The ObstacleDistanceOverlayVideo.qml probably needs this fix. There's also the VehicleObjectAvoidance class which seems to be entirely unused other than the distances array. This feature is currently broken in PX4 and I don't think anyone has used it in years. I want to resurrect the feature and make it all work again.

@DonLakeFlyer
Copy link
Contributor

@dakejahl Any updates on this. It's still marked Draft.

@dakejahl
Copy link
Contributor Author

No not yet, I haven't come back to working on this. The first step is to get the feature working again in PX4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants