Added support for displaying RPM MAVLink message in the main QGroundControl values panel #10757
+179
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonLakeFlyer
reviewed
Aug 7, 2023
src/FactSystem/FactGroup.cc
Outdated
| @@ -116,7 +116,8 @@ FactGroup* FactGroup::getFactGroup(const QString& name) | |||
| factGroup = _nameToFactGroupMap[camelCaseName]; | |||
| QQmlEngine::setObjectOwnership(factGroup, QQmlEngine::CppOwnership); | |||
| } else { | |||
| qWarning() << "Unknown FactGroup" << camelCaseName; | |||
| qWarning() << "Unknown FactGroup CC" << camelCaseName; | |||
There was a problem hiding this comment.
Could you change this to be "Unknown FactGroup (camelCaseName)"? That will make it way more clear.
There was a problem hiding this comment.
Sorry what I meant was to change to:
qWarning() << "Unknown FactGroup (camelCaseName)" << camelCaseName;
|
Hi @DonLakeFlyer, I have solved all your comments. Please, look at it again. Thank you |
|
Can you squash this into a single commit and then if the unit tests pass I'll merge. |
|
@roman-dvorak Can you squash, rebase to master and fix conflicts? |
|
@roman-dvorak Fix conflicts and squash? |
|
@roman-dvorak bump, if you could fix the conflicts, we'll get it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new feature to QGroundControl, enabling display value of RPM from MAVLink message on the main application window. With this update, users can now show and monitor up to four RPM values, which proves particularly useful for quadcopters.
To achieve this functionality, a new factView group has been created, allowing users to easily track RPM values in a clear panel within the main QGroundControl interface.
The functionality of the PR and features has been tested both with a custom-built QGC and with PX4 autopilot using TFRPM01 sensors, as well as with the PX4 simulator.