Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow backfilling DMs without double-puppeting enabled #686

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Allow backfilling DMs without double-puppeting enabled #686

wants to merge 8 commits into from

Conversation

leytilera
Copy link

Fixes #664

With this changes, backfilling in DMs also works correctly without double-puppeting enabled by inviting the puppet of the bridge user in DMs

tulir
tulir requested changes Feb 29, 2024
View reviewed changes
Copy link
Member

@tulir tulir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, people should just set up automatic double puppeting, there's no reason not to.

It might be fine to have this behind a config option, but it can't be the default since it spams all DM rooms with an unnecessary extra user.

@leytilera leytilera requested a review from tulir March 4, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulir tulir tulir approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Own sent messages are not synced
2 participants
@leytilera @tulir