Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sending heic images #636

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

raphaelcastaneda
Copy link

Implements feature request #635 by converting heic files to jpeg before attaching to a message

Implements feature request mautrix#635 by converting heic files
to jpeg before attaching to a message
@tulir
Copy link
Member

tulir commented Jul 23, 2023

That library looks unmaintained and doesn't work on arm/arm64. The amount of C code in general should also be minimized, I don't think there are any Go heif decoders.

@raphaelcastaneda
Copy link
Author

raphaelcastaneda commented Jul 31, 2023

There appears to be a fork of that library that does have arm support, but I'm not sure whether it's worth pursuing that given your other concerns.

@kinduff
Copy link

kinduff commented Feb 22, 2024

@raphaelcastaneda
Copy link
Author

@raphaelcastaneda Maybe klippa-app/go-libheif could work

This is a (really thin) wrapper around the much more active library: https://github.com/strukturag/libheif, so I'd opt to use that directly instead.

I think it's a question for @tulir whether usage of that library here is acceptable. This library is also based on a C implementation, but at least the underlying library (https://github.com/strukturag/libde265) appears to have arm support.

@niebloomj
Copy link

Why do we want the bridge to support a file type that whatsapp doesn't?

@tamcore
Copy link

tamcore commented Feb 22, 2024

Why do we want the bridge to support a file type that whatsapp doesn't?

That's the whole point. So the bridge can convert it to a supported format.

@niebloomj
Copy link

Makes sense 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants